Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Adding Support for DeepSpeed-MII #1226

Closed
jdries3 opened this issue Oct 23, 2022 · 5 comments
Closed

Consider Adding Support for DeepSpeed-MII #1226

jdries3 opened this issue Oct 23, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jdries3
Copy link
Contributor

jdries3 commented Oct 23, 2022

Is your feature request related to a problem? Please describe.
Recently Microsoft announced DeepSpeed-MII (DS-Public, https://github.com/microsoft/DeepSpeed) that adds support for a number of speed improvements for Deep Learning Training and Inference. If this can be tested/evaluated with InvokeAI's current architecture and proven an improvement, it might be worth the extra dependencies to incorporate.

Describe the solution you'd like
https://github.com/microsoft/DeepSpeed-MII/blob/main/examples/local/txt2img-example.py Shows some of the changes to use DeepSpeed-MII with the base Stable Diffusion release. Perhaps start there and validate whether any further work is warranted before launching into deeper implementation.

Additional context
There is an open issue (CompVis/stable-diffusion#180) to incorporate DeepSpeed-MII in upstream. There's been no movement on this since it was filed in September. But if this is incorporated upstream, this might end up being duplicative work.

@lstein lstein self-assigned this Oct 24, 2022
@lstein lstein added the enhancement New feature or request label Oct 24, 2022
@lstein
Copy link
Collaborator

lstein commented Oct 24, 2022

Thanks for the pointer. This looks very intriguing. Unfortunately it only works with the Hugging Face diffusers implementation of Stable Diffusion and won't work with our architecture. That being said, we're discussing porting to diffusers and this is yet another reason to do so.

Flagging @keturn, who is interested in doing a diffusers port.

@n00mkrad
Copy link

Should be mentioned that DeepSpeed effectively doesn't work on Windows.

@LifeIsStrange
Copy link

Note that Huggingface Accelerate exposé deepspeed cf CompVis/stable-diffusion#180 (comment)

@keturn
Copy link
Contributor

keturn commented Nov 24, 2022

I haven't looked in to the details, but I think the current state of things is that Accelerate has some integration for DeepSpeed, but not DeepSpeed Mii. DeepSpeed Mii being the thing that's more useful for inference.

@Millu Millu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants