Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: image gallery upscaling improvements #4288

Closed
1 task done
empessah opened this issue Aug 16, 2023 · 6 comments · Fixed by #5632
Closed
1 task done

[enhancement]: image gallery upscaling improvements #4288

empessah opened this issue Aug 16, 2023 · 6 comments · Fixed by #5632
Assignees
Labels
enhancement New feature or request gallery good first issue Good for new contributors

Comments

@empessah
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Contact Details

No response

What should this feature add?

Can we get some way to tell if an image is upscaled or how big an image is? I quickly wireframed up 2 ideas of just showing the Px dims or having the upscale icon on the graphic in the corner. bonus points if you can have both and just swap between within the settings

Alternatives

No response

Aditional Content

image

@empessah empessah added the enhancement New feature or request label Aug 16, 2023
@Millu Millu added gallery good first issue Good for new contributors labels Aug 23, 2023
@rohinish404
Copy link
Contributor

@psychedelicious how will this work?

@rohinish404
Copy link
Contributor

Can i get assigned? @psychedelicious

@psychedelicious
Copy link
Collaborator

@psychedelicious how will this work?

You'll have access to the imageDTO object in the GalleryImage component. That has the width and height, so you could display this information

Might be a good place for container queries - you could check the size of the image container element and use that to determine the visibility of the size badge.

Another option would be to use <Text /> with noOfLines={1}, which will truncate the text w/ an ellipsis

@rohinish404
Copy link
Contributor

@psychedelicious how will this work?

You'll have access to the imageDTO object in the GalleryImage component. That has the width and height, so you could display this information

Might be a good place for container queries - you could check the size of the image container element and use that to determine the visibility of the size badge.

Another option would be to use <Text /> with noOfLines={1}, which will truncate the text w/ an ellipsis

First focus is to get the dimensions only right? not the upscale?

@psychedelicious
Copy link
Collaborator

I don't think it's feasible to determine if an image is upscaled. It would require pulling its workflow (if it had one) and then parsing it. Showing the image size is probably as good as we will realistically get.

@rohinish404
Copy link
Contributor

I don't think it's feasible to determine if an image is upscaled. It would require pulling its workflow (if it had one) and then parsing it. Showing the image size is probably as good as we will realistically get.

understood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gallery good first issue Good for new contributors
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants