Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After Admin 5: adjust admin tab to no longer contain an icon #741

Open
UncleSamSwiss opened this issue May 5, 2021 · 3 comments · May be fixed by #754
Open

After Admin 5: adjust admin tab to no longer contain an icon #741

UncleSamSwiss opened this issue May 5, 2021 · 3 comments · May be fixed by #754

Comments

@UncleSamSwiss
Copy link
Collaborator

Admin tabs may not have own icons.
See comment here: ioBroker/ioBroker.admin#797 (comment)
@AlCalzone
Copy link
Collaborator

So in other words: we need to remove "fa-icon" from "adminTab"?

@AlCalzone
Copy link
Collaborator

In that case, it needs to be removed from the schema or the adapter creator's tests will fail.
@foxriver76

@AlCalzone AlCalzone linked a pull request May 15, 2021 that will close this issue
Draft
8 tasks
@foxriver76
Copy link

Let me know if you meant this, then I can remove it and publish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove icon from adminTab for Admin 5 ioBroker/create-adapter
3 participants
@UncleSamSwiss @AlCalzone @foxriver76