Read/Write-able attributes are not read

[allofmex]

Seems, toZigbee.js attributes from shepherd-converter are never read by ioBroker.zigbee.

I implemented #134, and it works for writing (type 'set'). The issue is that the value never gets read from device ('get').

It looks like it is not implemented yet:
(the "->>" lines should be changed as shown (key and error, resp arguments where missing))

          adapter.log.debug(`Read timeout for cmd '${message.cmd}' is ${readTimeout}`);
              setTimeout(()=>{
->>           const readMessage = converter.convert(key, preparedValue, preparedOptions, 'get');
                  if (readMessage) {
                      adapter.log.debug('read message: '+safeJsonStringify(readMessage));
                      // adapter.log.info(`3 before read publish. time: ${new Date() - start}`);
                      zbControl.publish(deviceId, readMessage.cid, readMessage.cmd, readMessage.zclData, ep, 
 ->>                          readMessage.cmdType, (error, resp)=>{
                          // adapter.log.info(`6 read publish success. ${stateDesc.id} time: ${new Date() - start}`);
                           ->> response ignored!  <<-
                      });
                      // adapter.log.info(`4 after read publish. time: ${new Date() - start}`);
                  }
              }, readTimeout || 0);

I tried to submit this as pull request, but git always shows the whole file as changed. Don't know why!?

Please implement the 'get' type too. Else we don't see current attribute value and if written values got accepted.

[arteck]

it's already in mine PR
arteck@6b26ff6

[allofmex]

Thanks, I see the fixed stateKey arguments.
But the read result is still ignored right? (callback empty)
So the value is never published, the Object just shows the last entered value or nothing if we never wrote something!?

[arteck]

But the read result is still ignored right? (callback empty)...

Yes you are right.. we send ON and the published state is also ON..
why should I read the state again ??

[allofmex]

1. The write may have failed or we wrote a illegal value. As of now the wrong value keeps showing in object and we don't get any feedback.
2. In case we never write anything, the Object should be read at least once to see current (default) setting

This is more needed for device settings that we not configure reporting for (timeouts,... Koenkk/zigbee-herdsman-converters#185), I guess it's not a good idea to add fromZigbee and reporting for all this rarely changed attributes...

[modmax]

I think this issue can be closed now.
With the definition of readAfterWriteStates this should be possible.

[allofmex]

Just one point: Would be nice to read all readAfterWrite states once after adapter start. Then we also see the device setting if we did not write anything. (maybe earliest 2 minutes after adapter start to limit the load right at startup. And right after device send something to be sure it is not sleeping)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.