Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External dependencies #39

Open
martinvilu opened this issue Jan 21, 2016 · 1 comment
Open

External dependencies #39

martinvilu opened this issue Jan 21, 2016 · 1 comment

Comments

@martinvilu
Copy link

Can't use Thingspeak as it is on the repository deployed inside an internal network because it's trying to fetch static resources from external CDN's.

Between lines

/app/views/layouts/_header.html.erb - Line 7

/app/views/layouts/_header.html.erb - Line 13

@davidjb
Copy link

davidjb commented Jun 14, 2016

In addition to these resources above, there's also a dependency on the licensed Highcharts JS (eg https://github.com/iobridge/thingspeak/blob/master/app/views/charts/show.html.erb) in several locations in the code used to display charts. The resources are hosted on thingspeak.com which is one thing, but also I'm curious as to whether it's a potential licence violation for me to be cloning this repo and reusing Highcharts (even if on that hosted location).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants