Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overzealous handling of spaces around square brackets ("[]") #47

Closed
fhightower opened this issue Apr 2, 2021 · 2 comments
Closed
Assignees
Labels

Comments

@fhightower
Copy link
Member

fhightower commented Apr 2, 2021

This is a derivate of #46.

Given:

ioc_fanger.fang('applications. [To')

We expect:

'applications. [To'

We get:

'applications.To'
@fhightower fhightower added the bug label Apr 2, 2021
@fhightower fhightower assigned fhightower and unassigned fhightower Apr 2, 2021
@fhightower fhightower changed the title Fix bug with angle brackets Fix overzealous handling of spaces around square brackets ("[]") Apr 6, 2021
@fhightower fhightower self-assigned this Apr 6, 2021
@git-yogeshkumar
Copy link

git-yogeshkumar commented Apr 7, 2021

@fhightower Just a question, have you considered giving support of angle brackets ('<>') for fanging IOCs. Cause my team has observed that there are scenarios where we get an IOC like 1<.>1<.>1<.>1. Of Course we can have this fanging to be strict (basically to avoid any html reformatting, just a thought). I would love to hear your thoughts on this!

@fhightower fhightower mentioned this issue Apr 8, 2021
@fhightower
Copy link
Member Author

Great idea @git-yogeshkumar, we can do that! We'll make the regex strict enough that it won't reformat any html. I'm tracking this idea in #52 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants