Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fang): incorrect \. regex #99

Merged
merged 3 commits into from
Sep 27, 2022
Merged

fix(fang): incorrect \. regex #99

merged 3 commits into from
Sep 27, 2022

Conversation

fhightower
Copy link
Member

@fhightower fhightower commented Sep 27, 2022

I intended this regex to match \., but instead, it was matching \ followed by any character.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (537ec0f) compared to base (ab8847f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           61        61           
=========================================
  Hits            61        61           
Impacted Files Coverage Δ
ioc_fanger/regexes_fang.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fhightower fhightower marked this pull request as ready for review September 27, 2022 11:23
@fhightower fhightower changed the title Fix incorrect find regex fix(fang): incorrect \. regex Sep 27, 2022
@fhightower fhightower merged commit 982acaa into main Sep 27, 2022
@fhightower fhightower deleted the fhightower-patch-1 branch September 27, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants