-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: don't confuse automatic headers for others
If you set a custom http header which includes eg. the string `Date`, then http will not automatically send the `Date` header. This is also true for other automatic http headers. PR-URL: #828 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
- Loading branch information
1 parent
25da074
commit 675cffb
Showing
3 changed files
with
37 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var http = require('http'); | ||
|
||
var server = http.createServer(function(req, res) { | ||
res.setHeader('X-Date', 'foo'); | ||
res.setHeader('X-Connection', 'bar'); | ||
res.setHeader('X-Transfer-Encoding', 'baz'); | ||
res.end(); | ||
}); | ||
server.listen(common.PORT); | ||
|
||
server.on('listening', function() { | ||
var agent = new http.Agent({ port: common.PORT, maxSockets: 1 }); | ||
http.get({ | ||
port: common.PORT, | ||
path: '/hello', | ||
agent: agent | ||
}, function(res) { | ||
assert.equal(res.statusCode, 200); | ||
assert.equal(res.headers['x-date'], 'foo'); | ||
assert.equal(res.headers['x-connection'], 'bar'); | ||
assert.equal(res.headers['x-transfer-encoding'], 'baz'); | ||
assert(res.headers['date']); | ||
assert.equal(res.headers['connection'], 'keep-alive'); | ||
assert.equal(res.headers['transfer-encoding'], 'chunked'); | ||
server.close(); | ||
agent.destroy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters