Skip to content

Commit f07b3b6

Browse files
committed
tools: set eslint comma-spacing to 'warn'
Certain cases with comments inside arrays or object literals fail to pass eslint's comma-spacing rule. This change sets the comma-spacing rule to the 'warn' level. Once eslint/eslint#2408 is resolved and released, this rule should be set back to 'error' level. PR-URL: #1672 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
1 parent 5755fc0 commit f07b3b6

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

.eslintrc

+5-6
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ rules:
4646
- 2
4747
- 2
4848
## add space after comma
49-
comma-spacing: 2
49+
## set to 'warn' because of https://github.com/eslint/eslint/issues/2408
50+
comma-spacing: 1
5051
## put semi-colon
5152
semi: 2
5253
## require spaces operator like var sum = 1 + 1;
@@ -56,21 +57,20 @@ rules:
5657
## require parens for Constructor
5758
new-parens: 2
5859
## max 80 length
59-
max-len:
60+
max-len:
6061
- 2
6162
- 80
6263
- 2
6364

64-
6565
# Strict Mode
6666
# list: https://github.com/eslint/eslint/tree/master/docs/rules#strict-mode
6767
## 'use strict' on top
68-
strict:
68+
strict:
6969
- 2
7070
- "global"
7171

7272
# Global scoped method and vars
73-
globals:
73+
globals:
7474
DTRACE_HTTP_CLIENT_REQUEST: true
7575
LTTNG_HTTP_CLIENT_REQUEST: true
7676
COUNTER_HTTP_CLIENT_REQUEST: true
@@ -89,4 +89,3 @@ globals:
8989
DTRACE_NET_SERVER_CONNECTION: true
9090
LTTNG_NET_SERVER_CONNECTION: true
9191
COUNTER_NET_SERVER_CONNECTION: true
92-

0 commit comments

Comments
 (0)