test: fix test-http-content-length #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Previously the test did not allow the last request to complete. Fixes: nodejs#1137 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Bert Belder <bertbelder@gmail.com>
Fishrock123
force-pushed
the
fix-test-http-content-length
branch
from
2ec4749 to
906ad71
Compare
Contributor
Author
|
Ahhh crap, I missed PR-URL. Should I amend it? cc @rvagg |
Contributor
Author
|
Pushed over it, thanks to @chrisdickinson for advising. |
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test did not allow the last request to complete on some platforms.
Fixes: #1137
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/296/
/cc @piscisaureus, @tellnes