-
Notifications
You must be signed in to change notification settings - Fork 77
/
test_redis_lock.py
683 lines (524 loc) · 20.6 KB
/
test_redis_lock.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
from __future__ import division
from __future__ import print_function
import gc
import logging
import multiprocessing
import platform
import sys
import threading
import time
from collections import defaultdict
from functools import partial
import pytest
from process_tests import TestProcess
from process_tests import dump_on_error
from process_tests import wait_for_strings
from redis import StrictRedis
from redis_lock import AlreadyAcquired
from redis_lock import InvalidTimeout
from redis_lock import Lock
from redis_lock import NotAcquired
from redis_lock import NotExpirable
from redis_lock import TimeoutNotUsable
from redis_lock import TimeoutTooLarge
from redis_lock import reset_all
from config import HELPER
from config import TIMEOUT
pytest_plugins = ('pytester',)
skipifpypy = partial(pytest.mark.skipif(platform.python_implementation() == 'PyPy'))
def maybe_decode(data):
if isinstance(data, bytes):
return data.decode('ascii')
else:
return data
@pytest.fixture(params=[True, False], ids=['decode_responses=True', 'decode_responses=False'])
def make_conn_plain(request, redis_server, redis_socket):
def conn_factory(**options):
options.setdefault('encoding_errors', 'replace')
conn = StrictRedis(unix_socket_path=redis_socket, **options)
request.addfinalizer(conn.flushdb)
return conn
return conn_factory
@pytest.fixture(params=[True, False], ids=['decode_responses=True', 'decode_responses=False'])
def make_conn(request, make_conn_plain):
return partial(make_conn_plain, decode_responses=request.param)
@pytest.fixture
def conn(request, make_conn):
return make_conn()
@pytest.fixture(
params=[
'normal',
'gevent',
pytest.param('eventlet', marks=skipifpypy(reason="apparently broken on PyPy")),
]
)
def effect(request):
def wrap_name_with_effect(name):
if request.param == 'normal':
return name
else:
return '{}:{}'.format(name, request.param)
wrap_name_with_effect.expected_impl = {
'normal': '_thread',
'gevent': 'gevent.thread',
'eventlet': 'eventlet.green.thread',
}[request.param]
return wrap_name_with_effect
@pytest.fixture
def make_process(request):
"""Process factory, that makes processes, that terminate themselves
after a test run.
"""
def make_process_factory(*args, **kwargs):
process = multiprocessing.Process(*args, **kwargs)
request.addfinalizer(process.terminate)
return process
return make_process_factory
def test_upgrade(conn, make_conn_plain):
legacy_conn = make_conn_plain(decode_responses=False)
lock = Lock(conn, "foobar")
legacy_conn.set(lock._name, b'\xd6{\xc93\xe9\xbd,\xdb\xb6\xa8<\x8ax\xd1<\xb9', nx=True, ex=lock._expire)
assert not lock.acquire(blocking=False)
def test_simple(redis_server, redis_socket, effect):
with TestProcess(sys.executable, HELPER, redis_socket, effect('test_simple')) as proc:
with dump_on_error(proc.read):
name = 'lock:foobar'
wait_for_strings(
proc.read,
TIMEOUT,
'Acquiring Lock(%r) ...' % name,
'Acquired Lock(%r).' % name,
'Releasing Lock(%r).' % name,
'DIED.',
)
def test_simple_auto_renewal(redis_server, redis_socket, effect, LineMatcher):
with TestProcess(sys.executable, HELPER, redis_socket, effect('test_simple_auto_renewal')) as proc:
with dump_on_error(proc.read):
name = 'lock:foobar'
wait_for_strings(
proc.read,
TIMEOUT,
'DIED.',
)
LineMatcher(proc.read().splitlines()).fnmatch_lines(
[
'* threading.get_ident.__module__=%s' % effect.expected_impl,
'* Acquiring Lock(%r) ...' % name,
'* Acquired Lock(%r).' % name,
'* Starting renewal thread for Lock(%r). Refresh interval: 0.6666666666666666 seconds.' % name,
'* Refreshing Lock(%r).' % name,
'* Refreshing Lock(%r).' % name,
'* Signaling renewal thread for Lock(%r) to exit.' % name,
'* Exiting renewal thread for Lock(%r).' % name,
'* Renewal thread for Lock(%r) exited.' % name,
'* Releasing Lock(%r).' % name,
]
)
def test_no_block(conn, redis_socket):
with Lock(conn, "foobar"):
with TestProcess(sys.executable, HELPER, redis_socket, 'test_no_block') as proc:
with dump_on_error(proc.read):
name = 'lock:foobar'
wait_for_strings(
proc.read,
TIMEOUT,
'Acquiring Lock(%r) ...' % name,
'Failed to acquire Lock(%r).' % name,
'acquire=>False',
'DIED.',
)
def test_timeout(conn):
with Lock(conn, "foobar"):
lock = Lock(conn, "foobar")
assert lock.acquire(timeout=1) is False
@pytest.mark.parametrize("timeout", [0, "0", "123"])
def test_timeout_int_conversion(conn, timeout):
lock = Lock(conn, "foobar")
lock.acquire(blocking=True, timeout=timeout)
lock.release()
def test_timeout_expire(conn):
lock1 = Lock(conn, "foobar", expire=1)
lock1.acquire()
lock2 = Lock(conn, "foobar")
assert lock2.acquire(timeout=2)
def test_timeout_expire_with_renewal(conn):
with Lock(conn, "foobar", expire=1, auto_renewal=True):
lock = Lock(conn, "foobar")
assert lock.acquire(timeout=2) is False
def test_timeout_acquired(conn, redis_socket):
with TestProcess(sys.executable, HELPER, redis_socket, 'test_timeout') as proc:
with dump_on_error(proc.read):
name = 'lock:foobar'
wait_for_strings(
proc.read,
TIMEOUT,
'Acquiring Lock(%r) ...' % name,
'Acquired Lock(%r).' % name,
)
lock = Lock(conn, "foobar")
assert lock.acquire(timeout=2)
def test_not_usable_timeout(conn):
lock = Lock(conn, "foobar")
with pytest.raises(TimeoutNotUsable):
lock.acquire(blocking=False, timeout=1)
def test_expire_less_than_timeout(conn):
lock = Lock(conn, "foobar", expire=1)
pytest.raises(TimeoutTooLarge, lock.acquire, blocking=True, timeout=2)
lock = Lock(conn, "foobar", expire=1, auto_renewal=True)
lock.acquire(blocking=True, timeout=2)
lock.release()
def test_invalid_timeout(conn):
lock = Lock(conn, "foobar")
pytest.raises(InvalidTimeout, lock.acquire, blocking=True, timeout=-123)
lock = Lock(conn, "foobar")
pytest.raises(InvalidTimeout, lock.acquire, blocking=True, timeout=-1)
pytest.raises(ValueError, lock.acquire, blocking=True, timeout="foobar")
def test_expire_int_conversion():
conn = object()
lock = Lock(conn, name='foobar', strict=False, expire=1)
assert lock._expire == 1
lock = Lock(conn, name='foobar', strict=False, expire=0)
assert lock._expire is None
lock = Lock(conn, name='foobar', strict=False, expire="1")
assert lock._expire == 1
lock = Lock(conn, name='foobar', strict=False, expire="123")
assert lock._expire == 123
def test_expire(conn, redis_socket):
lock = Lock(conn, "foobar", expire=TIMEOUT / 4)
lock.acquire()
with TestProcess(sys.executable, HELPER, redis_socket, 'test_expire') as proc:
with dump_on_error(proc.read):
name = 'lock:foobar'
wait_for_strings(
proc.read,
TIMEOUT,
'Acquiring Lock(%r) ...' % name,
'Acquired Lock(%r).' % name,
'Releasing Lock(%r).' % name,
'DIED.',
)
lock = Lock(conn, "foobar")
try:
assert lock.acquire(blocking=False) is True
finally:
lock.release()
def test_expire_without_timeout(conn):
first_lock = Lock(conn, 'expire', expire=2)
second_lock = Lock(conn, 'expire', expire=1)
first_lock.acquire()
assert second_lock.acquire(blocking=False) is False
assert second_lock.acquire() is True
second_lock.release()
def test_extend(conn):
name = 'foobar'
key_name = 'lock:' + name
with Lock(conn, name, expire=100) as lock:
assert conn.ttl(key_name) <= 100
lock.extend(expire=1000)
assert conn.ttl(key_name) > 100
def test_extend_lock_default_expire(conn):
name = 'foobar'
key_name = 'lock:' + name
with Lock(conn, name, expire=1000) as lock:
time.sleep(3)
assert conn.ttl(key_name) <= 997
lock.extend()
assert 997 < conn.ttl(key_name) <= 1000
def test_extend_lock_without_expire_fail(conn):
name = 'foobar'
with Lock(conn, name) as lock:
with pytest.raises(NotExpirable):
lock.extend(expire=1000)
with pytest.raises(TypeError):
lock.extend()
def test_extend_another_instance(conn):
"""It is possible to extend a lock using another instance of Lock with the
same name.
"""
name = 'foobar'
key_name = 'lock:' + name
lock = Lock(conn, name, expire=100)
lock.acquire()
assert 0 <= conn.ttl(key_name) <= 100
another_lock = Lock(conn, name, id=lock.id)
another_lock.extend(1000)
assert conn.ttl(key_name) > 100
def test_extend_another_instance_different_id_fail(conn):
"""It is impossible to extend a lock using another instance of Lock with
the same name, but different id.
"""
name = 'foobar'
key_name = 'lock:' + name
lock = Lock(conn, name, expire=100)
lock.acquire()
assert 0 <= conn.ttl(key_name) <= 100
another_lock = Lock(conn, name)
with pytest.raises(NotAcquired):
another_lock.extend(1000)
assert conn.ttl(key_name) <= 100
assert lock.id != another_lock.id
def test_double_acquire(conn):
lock = Lock(conn, "foobar")
with lock:
pytest.raises(RuntimeError, lock.acquire)
pytest.raises(AlreadyAcquired, lock.acquire)
def test_enter_already_acquired_with_not_blocking(conn):
lock = Lock(conn, "foobar")
acquired = lock.acquire()
assert acquired
with pytest.raises(NotAcquired):
with Lock(conn, "foobar", blocking=False):
pass
def test_plain(conn):
with Lock(conn, "foobar"):
time.sleep(0.01)
def test_no_overlap(redis_server, redis_socket):
"""
This test tries to simulate contention: lots of clients trying to acquire at the same time.
If there would be a bug that would allow two clients to hold the lock at the same time it
would most likely regress this test.
The code here mostly tries to parse out the pid of the process and the time when it got and
released the lock. If there's is overlap (eg: pid1.start < pid2.start < pid1.end) then we
got a very bad regression on our hands ...
The subprocess being run (check helper.py) will fork bunch of processes and will try to
syncronize them (using the builting sched) to try to acquire the lock at the same time.
"""
with TestProcess(sys.executable, HELPER, redis_socket, 'test_no_overlap') as proc:
with dump_on_error(proc.read):
name = 'lock:foobar'
wait_for_strings(proc.read, 10 * TIMEOUT, 'Acquiring Lock(%r) ...' % name)
wait_for_strings(proc.read, 10 * TIMEOUT, 'Acquired Lock(%r).' % name)
wait_for_strings(proc.read, 10 * TIMEOUT, 'Releasing Lock(%r).' % name)
wait_for_strings(proc.read, 10 * TIMEOUT, 'DIED.')
class Event(object):
pid = start = end = '?'
def __str__(self):
return "Event(%s; %r => %r)" % (self.pid, self.start, self.end)
events = defaultdict(Event)
for line in proc.read().splitlines():
try:
pid, time, junk = line.split(' ', 2)
pid = int(pid)
except ValueError:
continue
if 'Got lock for' in junk:
events[pid].pid = pid
events[pid].start = time
if 'Releasing' in junk:
events[pid].pid = pid
events[pid].end = time
assert len(events) == 125
# not very smart but we don't have millions of events so it's
# ok - compare all the events with all the other events:
for event in events.values():
for other in events.values():
if other is not event:
try:
if other.start < event.start < other.end or other.start < event.end < other.end:
pytest.fail('%s overlaps %s' % (event, other))
except Exception:
print("[%s/%s]" % (event, other))
raise
def _no_overlap2_workerfn(redis_socket, event, count_lock, count):
logging.basicConfig(level=logging.DEBUG)
with StrictRedis(unix_socket_path=redis_socket) as conn:
redis_lock = Lock(conn, 'lock')
with count_lock:
count.value += 1
event.wait()
if redis_lock.acquire(blocking=True):
with count_lock:
count.value += 1
@skipifpypy(reason="way too slow to run on PyPy")
def test_no_overlap2(make_process, redis_server, redis_socket):
"""The second version of contention test, that uses multiprocessing."""
event = multiprocessing.Event()
count_lock = multiprocessing.Lock()
count = multiprocessing.Value('H', 0)
for _ in range(125):
make_process(target=_no_overlap2_workerfn, args=(redis_socket, event, count_lock, count)).start()
# Wait until all workers will come to point when they are ready to acquire
# the redis lock.
while count.value < 125:
time.sleep(0.5)
# Then "count" will be used as counter of workers, which acquired
# redis-lock with success.
count.value = 0
event.set()
time.sleep(1)
assert count.value == 1
def test_reset(conn):
lock = Lock(conn, "foobar")
lock.reset()
new_lock = Lock(conn, "foobar")
new_lock.acquire(blocking=False)
new_lock.release()
pytest.raises(NotAcquired, lock.release)
def test_reset_all(conn):
lock1 = Lock(conn, "foobar1")
lock2 = Lock(conn, "foobar2")
lock1.acquire(blocking=False)
lock2.acquire(blocking=False)
reset_all(conn)
lock1 = Lock(conn, "foobar1")
lock2 = Lock(conn, "foobar2")
lock1.acquire(blocking=False)
lock2.acquire(blocking=False)
lock1.release()
lock2.release()
def test_owner_id(conn):
unique_identifier = "foobar-identifier"
lock = Lock(conn, "foobar-tok", expire=TIMEOUT / 4, id=unique_identifier)
lock_id = lock.id
assert lock_id == unique_identifier
def test_get_owner_id(conn):
lock = Lock(conn, "foobar-tok")
lock.acquire()
assert lock.get_owner_id() == lock.id
lock.release()
def test_token(conn):
lock = Lock(conn, "foobar-tok")
tok = lock.id
assert conn.get(lock._name) is None
lock.acquire(blocking=False)
assert maybe_decode(conn.get(lock._name)) == tok
def test_bogus_release(conn):
lock = Lock(conn, "foobar-tok")
pytest.raises(NotAcquired, lock.release)
lock.acquire()
lock2 = Lock(conn, "foobar-tok", id=lock.id)
lock2.release()
def test_release_from_nonblocking_leaving_garbage(conn):
for _ in range(10):
lock = Lock(conn, 'release_from_nonblocking')
lock.acquire(blocking=False)
lock.release()
assert conn.llen('lock-signal:release_from_nonblocking') == 1
def test_no_auto_renewal(conn):
lock = Lock(conn, 'lock_renewal', expire=3, auto_renewal=False)
assert lock._lock_renewal_interval is None
lock.acquire()
assert lock._lock_renewal_thread is None, "No lock refresh thread should have been spawned"
def test_auto_renewal_bad_values(conn):
with pytest.raises(ValueError):
Lock(conn, 'lock_renewal', expire=None, auto_renewal=True)
def test_auto_renewal(conn):
lock = Lock(conn, 'lock_renewal', expire=3, auto_renewal=True)
lock.acquire()
assert isinstance(lock._lock_renewal_thread, threading.Thread)
assert not lock._lock_renewal_stop.is_set()
assert isinstance(lock._lock_renewal_interval, float)
assert lock._lock_renewal_interval == 2
time.sleep(3)
assert maybe_decode(conn.get(lock._name)) == lock.id, "Key expired but it should have been getting renewed"
lock.release()
assert lock._lock_renewal_thread is None
@pytest.mark.parametrize('signal_expire', [1000, 1500])
@pytest.mark.parametrize('method', ['release', 'reset_all'])
def test_signal_expiration(conn, signal_expire, method):
"""Signal keys expire within two seconds after releasing the lock."""
lock = Lock(conn, 'signal_expiration', signal_expire=signal_expire)
lock.acquire()
if method == 'release':
lock.release()
elif method == 'reset_all':
reset_all(conn)
time.sleep(0.5)
assert conn.exists('lock-signal:signal_expiration')
time.sleep((signal_expire - 500) / 1000.0)
assert conn.llen('lock-signal:signal_expiration') == 0
def test_reset_signalizes(make_conn, make_process):
"""Call to reset() causes LPUSH to signal key, so blocked waiters
become unblocked."""
def workerfn(unblocked):
conn = make_conn()
lock = Lock(conn, 'lock')
if lock.acquire():
unblocked.value = 1
unblocked = multiprocessing.Value('B', 0)
conn = make_conn()
lock = Lock(conn, 'lock')
lock.acquire()
worker = make_process(target=workerfn, args=(unblocked,))
worker.start()
worker.join(0.5)
lock.reset()
worker.join(0.5)
assert unblocked.value == 1
def test_reset_all_signalizes(make_conn, make_process):
"""Call to reset_all() causes LPUSH to all signal keys, so blocked waiters
become unblocked."""
def workerfn(unblocked):
conn = make_conn()
lock1 = Lock(conn, 'lock1')
lock2 = Lock(conn, 'lock2')
if lock1.acquire() and lock2.acquire():
unblocked.value = 1
unblocked = multiprocessing.Value('B', 0)
conn = make_conn()
lock1 = Lock(conn, 'lock1')
lock2 = Lock(conn, 'lock2')
lock1.acquire()
lock2.acquire()
worker = make_process(target=workerfn, args=(unblocked,))
worker.start()
worker.join(0.5)
reset_all(conn)
worker.join(0.5)
assert unblocked.value == 1
def test_auto_renewal_stops_after_gc(conn):
"""Auto renewal stops after lock is garbage collected."""
lock = Lock(conn, 'spam', auto_renewal=True, expire=1)
name = lock._name
lock.acquire(blocking=True)
lock_renewal_thread = lock._lock_renewal_thread
del lock
gc.collect()
slept = 0
interval = 0.1
while slept <= 5:
slept += interval
lock_renewal_thread.join(interval)
if not lock_renewal_thread.is_alive():
break
time.sleep(1.5)
assert not lock_renewal_thread.is_alive()
assert conn.get(name) is None
def test_given_id(conn):
"""It is possible to extend a lock using another instance of Lock with the
same name.
"""
name = 'foobar'
key_name = 'lock:' + name
orig = Lock(conn, name, expire=100, id=b"a")
orig.acquire()
pytest.raises(TypeError, Lock, conn, name, id=object())
lock = Lock(conn, name, id=b"a")
pytest.raises(AlreadyAcquired, lock.acquire)
lock.extend(100)
lock.release() # this works, note that this ain't the object that acquired the lock
pytest.raises(NotAcquired, orig.release) # and this fails because lock was released above
assert conn.ttl(key_name) == -2
def test_strict_check():
pytest.raises(ValueError, Lock, object(), name='foobar')
Lock(object(), name='foobar', strict=False)
def test_borken_expires():
conn = object()
pytest.raises(ValueError, Lock, redis_client=conn, name='foobar', expire=-1)
pytest.raises(ValueError, Lock, redis_client=conn, name='foobar', expire=-123)
pytest.raises(ValueError, Lock, redis_client=conn, name='foobar', expire="-1")
lock = Lock(redis_client=conn, name='foobar', strict=False)
pytest.raises(ValueError, lock.extend, expire=-1)
pytest.raises(ValueError, lock.extend, expire=-123)
pytest.raises(ValueError, lock.extend, expire="-1")
def test_locked_method(conn):
lock_name = 'lock_name'
lock = Lock(conn, lock_name, id='first')
another_lock = Lock(conn, lock_name, id='another')
assert lock.locked() is False
assert another_lock.locked() is False
assert lock.acquire() is True
# another lock has same name and different id,
# but method returns true
assert lock.locked() is True
assert another_lock.locked() is True