-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geolocation): add minimumUpdateInterval
parameter for startWatch
#2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: For Android >= 10, we don't need to request permissions to save the photo to the gallery. More info here: https://developer.android.com/media/camera/camera-deprecated/photobasics#TaskPath References: https://outsystemsrd.atlassian.net/browse/RMET-3767
… (API 28)" This reverts commit 03a151f.
Context: We were hardcoding the minimum update interval for location updates to 5 seconds, which meant that if there was an update available in less than 5 seconds, that update would only be delivered after 5 seconds. Instead, this value should be set by the user/developer, so they can better control the frequency of location updates. References: https://outsystemsrd.atlassian.net/browse/RMET-3338
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
December 5, 2024 14:24
OS-martacarlos
approved these changes
Dec 6, 2024
OS-ricardomoreirasilva
approved these changes
Dec 6, 2024
ItsChaceD
requested changes
Dec 6, 2024
Released dev build of geolocation with dev version: 7.0.0-dev-2272-20241206T174019.0 |
ItsChaceD
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimumUpdateInterval
toPositionOptions
so that it can be used when building theLocationRequest
for Android on thestartWatch
feature.Solves: #2062
References: https://outsystemsrd.atlassian.net/browse/RMET-3338