Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added JS example to iOS custom-code section #2015

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

nip3o
Copy link
Contributor

@nip3o nip3o commented Oct 1, 2019

It's already well-documented, but adding a JS example means that you can just copy-paste instructions and start playing around right away.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this gets added to the iOS custom code guide, should be added to the Android custom code guide too.

@nip3o
Copy link
Contributor Author

nip3o commented Oct 21, 2019

Yeah, I agree.

We just released our (Capacitor-based) app so I have limited time for contributing right now, but I'll have a look at my PR:s this or next week.

@nip3o
Copy link
Contributor Author

nip3o commented Nov 8, 2019

Turns out a similar section was added to the Android docs in #1857. Still no note about it in iOS docs, so with this change we have docs for both platforms.

@jcesarmobile jcesarmobile changed the title Added JS example to ios/custom-code docs docs: Added JS example to iOS custom-code section Nov 13, 2019
@jcesarmobile jcesarmobile merged commit c1a7e20 into ionic-team:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants