fix(core): improve Filesystem parameter descriptions #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Oct 15, 2019
There was a problem hiding this comment.
Thanks for the PR.
I don't really like the get the path under nor sub-directory. Can you just change remove to read?
Also, there are similar problems in other descriptions such as StatOptions, can you check all the other Filesystem related string and fix this kind of problems and make them look similar?
|
I skimmed through all docstrings in the entire file, seems ReaddirOptions and StatOptions were the only incorrect ones. Also slightly changed the ReaddirOptions text, see if you like it better now. |
nip3o
changed the title
jcesarmobile
approved these changes
Nov 13, 2019
jcesarmobile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.