Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera source prompt-mode and translations #2113

Closed
sandstrom opened this issue Oct 30, 2019 · 4 comments
Closed

Camera source prompt-mode and translations #2113

sandstrom opened this issue Oct 30, 2019 · 4 comments

Comments

@sandstrom
Copy link
Contributor

sandstrom commented Oct 30, 2019

Thanks for a great framework! 🎖

When using the camera plugin with the prompt source value, one can choose between using the camera and picking from the library. So far so good.

However, the prompt is always displayed in english with no ability to provide override values.

Would be neat if we could pass strings that would override the default, so we could use this in any locale.

Is this something you've considered adding?

Here is an example of the types of strings we'd like to modify:
https://github.com/ionic-team/capacitor/blob/871651b/ios/Capacitor/Capacitor/Plugins/Camera.swift#L104-L114

@jcesarmobile
Copy link
Member

There is already an issue for localizing all the plugin messages
#872

@sandstrom
Copy link
Contributor Author

@jcesarmobile I think it's easier to simply make the handful of strings configurable. That way we can use our existing localization mechanism.

I've written down my thoughts on this in this comment: #872 (comment)

If you agree with me, I'd suggest reopening this issue to track full localization support for this plugin.

@sandstrom
Copy link
Contributor Author

Fixed in #2631

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants