discuss: Android catches all plugin exceptions and logs message while iOS allows them to crash the app. Should they be made to work the same across platforms?

[josh-m-sharpe]

In trying to create a plugin for Firebase Crashlytics, it seems that @capacitor/ios allows exceptions within a plugin method to bubble all the way up and crash the app and @capacitor/android catches all exceptions and logs a simple message. Android code is here and here.

To me, the Android implementation seems like it could hide problems within the plugin, never to be seen or reported by tools like Crashlytics. While good intentioned, this seems like a bad idea overall.

Would the Capacitor team welcome PRs that remove the exception catching logic from the android platform?

[priyankpat]

I wouldn't necessarily remove exception checks and use notifyListener to transmit errors, which can be handled by the web app?

[josh-m-sharpe]

I think that approach would work too. Either way, I suspect it makes sense to update all platforms to work the same.

It would be good to hear from the internal team on this though.

[jcesarmobile]

I agree, will add this to the 2.0.0 milestone

[nphyatt]

My gut says that it would be ideal to not catch the unexpected exceptions similar to how a regular native app would work. Plugins should catch exceptions they expect and return the appropriate responses. If an exception occurs that is not expected code should be fixed to handle it as the web side of the app really has no context in how to do so.

[jcesarmobile]

@josh-m-sharpe, I've sent a PR, let me know what do you think

[josh-m-sharpe]

Seems solid. Thanks!

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.