fix(cli): use proper kebab-case name for npm package #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
reviewed
Jan 9, 2020
| @@ -34,7 +34,7 @@ This starts a wizard prompting you for information about your new plugin. For ex | |||
| ```bash | |||
| npx @capacitor/cli plugin:generate | |||
| ✏️ Creating new Capacitor plugin | |||
| ? Plugin NPM name (snake-case): my-plugin | |||
| ? Plugin NPM name (kebab-case): my-plugin | |||
There was a problem hiding this comment.
good catch, can you also change it in line 47?
jcesarmobile
changed the title
The recommended case of the plugin-name is actually [kebab-case][wikipedia] not snake-case. [wikipedia]: https://en.wikipedia.org/wiki/Letter_case#Special_case_styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended case of the plugin-name is actually
kebab-case not snake-case.