Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ce-plugins): add capacitor-voice-recorder #2378

Merged
merged 2 commits into from
Jan 30, 2020
Merged

docs(ce-plugins): add capacitor-voice-recorder #2378

merged 2 commits into from
Jan 30, 2020

Conversation

tchvu3
Copy link
Contributor

@tchvu3 tchvu3 commented Jan 28, 2020

Added voice recording plugin for ios and android

@tchvu3
Update plugins.md
df5fdea 
Added voice recording plugin for ios and android
jcesarmobile
jcesarmobile requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an audio section that is empty at the moment, better move it there

@tchvu3
Update plugins.md
e03869d 
moved the plugin to the "audio" category
@tchvu3
Copy link
Contributor Author

tchvu3 commented Jan 30, 2020

moved to the required section

jcesarmobile
jcesarmobile approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jcesarmobile jcesarmobile changed the title Update plugins.md docs(ce-plugins): add capacitor-voice-recorder Jan 30, 2020
@jcesarmobile jcesarmobile merged commit 9836d05 into ionic-team:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchvu3 @jcesarmobile