Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add configuration option for allowsLinkPreview #2382

Merged
merged 4 commits into from
Jan 29, 2020

Conversation

brian-g
Copy link
Contributor

@brian-g brian-g commented Jan 29, 2020

Turn off link previews by default in WkWebView instances created by Capacitor. Generally speaking this is the right behavior for a web app and is more usable for people with motor difficultities.

https://developer.apple.com/documentation/webkit/wkwebview/1415000-allowslinkpreview

This fixes issue #2381

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be configurable from capacitor.config.json

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Would be good if you could send another PR documenting the preference https://capacitor.ionicframework.com/docs/basics/configuring-your-app

@jcesarmobile jcesarmobile changed the title Disable linkPreviews in WkWebView instances feat(ios): add configuration option for allowsLinkPreview Jan 29, 2020
@jcesarmobile jcesarmobile merged commit 47b4d66 into ionic-team:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants