Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: generated cordova plugin AndroidManifest.xml is incorrect #2440

Closed
1 of 4 tasks
donald-hanson opened this issue Feb 14, 2020 · 1 comment · Fixed by #2478
Closed
1 of 4 tasks

bug: generated cordova plugin AndroidManifest.xml is incorrect #2440

donald-hanson opened this issue Feb 14, 2020 · 1 comment · Fixed by #2478

Comments

@donald-hanson
Copy link

donald-hanson commented Feb 14, 2020

Bug Report

Capacitor Version

npx cap doctor output:

Latest Dependencies:

  @capacitor/cli: 1.5.0

  @capacitor/core: 1.5.0

  @capacitor/android: 1.5.0

  @capacitor/ios: 1.5.0

Installed Dependencies:

  @capacitor/cli 1.5.0

  @capacitor/core 1.5.0

  @capacitor/android 1.5.0

  @capacitor/ios 1.5.0

Affected Platform(s)

  • Android
  • iOS
  • Electron
  • Web

Current Behavior

The generated AndroidManifest.xml looks like the following:

...
<application android:name="com.darryncampbell.cordova.plugin.intent.CordovaPluginIntentFileProvider"
android:authorities="${applicationId}.darryncampbell.cordova.plugin.intent.fileprovider"
android:exported="false"
android:grantUriPermissions="true">

</application>
...

Expected Behavior

The generated AndroidManifest.xml file should look like the following:

...
<application>
<provider android:name="com.darryncampbell.cordova.plugin.intent.CordovaPluginIntentFileProvider" android:authorities="${applicationId}.darryncampbell.cordova.plugin.intent.fileprovider" android:exported="false" android:grantUriPermissions="true">
  <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/provider_paths"/>
</provider>
</application>
...

Sample Code or Sample Application Repo

See this GitHub repo for examples of actual and expected results.

Reproduction Steps

Install com-darryncampbell-cordova-plugin-intent plugin:

npm install com-darryncampbell-cordova-plugin-intent@1.3.0

Sync android:

npx cap sync android

Review android\capacitor-cordova-android-plugins\src\main\AndroidManifest.xml

Other Technical Details

npm --version output:

6.13.7

node --version output:

v10.13.0

pod --version output (iOS issues only):

Other Information

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant