Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add device name to Device.getInfo() #2491

Merged
merged 5 commits into from Mar 9, 2020
Merged

feat(ios): add device name to Device.getInfo() #2491

merged 5 commits into from Mar 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 26, 2020

closes #2130

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 comments

core/src/core-plugin-definitions.ts Outdated Show resolved Hide resolved
core/src/core-plugin-definitions.ts Show resolved Hide resolved
jstjnsn and others added 2 commits February 28, 2020 10:06
Property is iOS only so it has to be optional.

Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
@ghost
Copy link
Author

ghost commented Feb 28, 2020

Changes should be all good now. Thanks for guiding me jcesarmobile, I'm learning stuff!

@jcesarmobile jcesarmobile changed the title Include current device name in getInfo return feat(ios): add device name to Device.getInfo() Mar 9, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jcesarmobile jcesarmobile merged commit 4fb244d into ionic-team:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Include device name in device info
1 participant