-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): add device name to Device.getInfo() #2491
Conversation
Pull request for #2130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also have to edit the types to add the name
https://github.com/ionic-team/capacitor/blob/master/core/src/core-plugin-definitions.ts#L410
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 comments
Property is iOS only so it has to be optional. Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
Changes should be all good now. Thanks for guiding me jcesarmobile, I'm learning stuff! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
closes #2130