docs: Add Deep Links guide #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I think the link on the side should say "Deeplinking" which will be more obvious/identifiable by most people |
|
nice, I am going to try this... noticed this am that I hadn't updated the config since moving to Capacitor and I would love to get rid of the Cordova plugin |
jcesarmobile
requested changes
Mar 19, 2020
There was a problem hiding this comment.
Added a few comments.
I find confusing that we say deep links support web platform when App plugin doesn't have appUrlOpen event on web platform.
While is true that regular links work on web, deep links are related to apps, not to web.
Maybe reword in a way that it says that deep links will fallback to regular links on web or something like that, but don't say deep links are supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to implement this for a personal app, so turned it into a Capacitor guide.
Used my app for screenshots, video, etc examples - could switch to something more generic but thought it would be good to use a real example (instead of "yourwebsite.com" everywhere).
Still need to add React code, but wanted early feedback.