fix(docs/camera): add usage descriptions for using in iOS #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Mar 25, 2020
| @@ -218,7 +218,7 @@ Next, for the Camera plugin to work, we must configure the "Privacy - Camera Usa | |||
|
|
|||
| Each setting in `Info.plist` has a low-level parameter name and a high-level name. By default, the property list editor shows the high-level names, but it's often useful to switch to showing the raw, low-level names. To do this, right-click anywhere in the property list editor and toggle "Show Raw Keys/Values." | |||
|
|
|||
| Locate the `NSCameraUsageDescription` Key (or add it) and set the Value to something that describes why the app needs to use the camera, such as "To Take Photos." The Value will be displayed to the app user when the permission prompt opens. | |||
| Locate the `NSCameraUsageDescription` Key (or add it) and set the Value to something that describes why the app needs to use the camera, such as "To Take Photos." The Value will be displayed to the app user when the permission prompt opens. Do the same for `NSPhotoLibraryAddUsageDescription` Key and `NSPhotoLibraryUsageDescription` Key. | |||
There was a problem hiding this comment.
The sample apps doesn't read or save to the gallery, so those two are not needed for the guide.
|
@jcesarmobile Thanks for review. I removed tutorial change. thanks. |
jcesarmobile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capacitor's camera plugin is require three permission: https://github.com/ionic-team/capacitor/blob/master/ios/Capacitor/Capacitor/Plugins/Camera.swift#L348-L373
But now, docs said require one permission. This pull request is fix this.
Thanks.