-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Push Notifications with Firebase Guide #2698
Conversation
- References to Ionic 5 instead of Ionic 4. - Prompts to install the '@ionic/cli' instead of previous 'ionic' cli package. - Reminds user to build and copy web assets to capacitor after writing code. - Adds instructions on Android app creation
There's also a broken link here:
I don't know how to fix it, because it works properly on localhost, but deployed it's adding the word 'guides' to the URL. |
You can ignore this, as it's rendering the link correctly when deployed. I think the difference is the path generated locally vs when deployed. Annoying but OK for now. good call out though :) |
Hey y'all, this PR pushes a few updates on the push notifications article:
ionic
CLI package. Changed to install the@ionic/cli
.home.page.ts
there was no notice that the user needed to run a new build andnpx cap copy
to copy web assets to the android application, so that code wasn't getting executed.