Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Push Notifications with Firebase Guide #2698

Merged
merged 5 commits into from
Apr 14, 2020
Merged

Updates Push Notifications with Firebase Guide #2698

merged 5 commits into from
Apr 14, 2020

Conversation

javebratt
Copy link
Contributor

Hey y'all, this PR pushes a few updates on the push notifications article:

  • Most of the references where to Ionic 4. Changed it to reference to Ionic 5.
  • The first part was prompting the user to install the old ionic CLI package. Changed to install the @ionic/cli.
  • After we add the code to the home.page.ts there was no notice that the user needed to run a new build and npx cap copy to copy web assets to the android application, so that code wasn't getting executed.
  • The instructions to add a new android app in Firebase worked only for new projects, existing projects didn't have that Icon so added some more details and a picture to show where to create it.

- References to Ionic 5 instead of Ionic 4.
- Prompts to install the '@ionic/cli' instead of previous 'ionic' cli package.
- Reminds user to build and copy web assets to capacitor after writing code.
- Adds instructions on Android app creation
@dotNetkow dotNetkow self-requested a review April 5, 2020 15:05
@javebratt
Copy link
Contributor Author

There's also a broken link here:

Building and deploying iOS and Android applications using Capacitor requires a bit of setup. Please follow the instructions to install the necessary Capacitor dependencies here before continuing.

I don't know how to fix it, because it works properly on localhost, but deployed it's adding the word 'guides' to the URL.

@dotNetkow
Copy link
Contributor

There's also a broken link here:

Building and deploying iOS and Android applications using Capacitor requires a bit of setup. Please follow the instructions to install the necessary Capacitor dependencies here before continuing.

I don't know how to fix it, because it works properly on localhost, but deployed it's adding the word 'guides' to the URL.

You can ignore this, as it's rendering the link correctly when deployed. I think the difference is the path generated locally vs when deployed. Annoying but OK for now. good call out though :)

@dotNetkow dotNetkow merged commit ee5e283 into ionic-team:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants