fix(ios): don't use the tmpWindow on popover presentation #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nphyatt
approved these changes
Apr 7, 2020
chriswep
reviewed
Apr 8, 2020
| @@ -23,7 +23,7 @@ public class CAPBrowserPlugin : CAPPlugin, SFSafariViewControllerDelegate { | |||
| self.vc = SFSafariViewController.init(url: url!) | |||
| self.vc!.delegate = self | |||
| let presentationStyle = call.getString("presentationStyle") | |||
| if presentationStyle != nil && presentationStyle == "popover" { | |||
| if presentationStyle != nil && presentationStyle == "popover" && UIDevice.current.userInterfaceIdiom == .pad { | |||
There was a problem hiding this comment.
does this mean that popover presentation on iPhone is gone? is there a reason for this? i liked the iOS13 modal-style of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the tmpWindow doesn't work fine when using popover presentation, and since popover presentation doesn't freeze the javascript, changed the code to not use the tmpWindow when the presentation is popover
closes #2711