Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: showActions does not use title or message parameters on ANdroid #2723

Closed
1 of 4 tasks
Justin-Credible opened this issue Apr 7, 2020 · 1 comment · Fixed by #2730
Closed
1 of 4 tasks

bug: showActions does not use title or message parameters on ANdroid #2723

Justin-Credible opened this issue Apr 7, 2020 · 1 comment · Fixed by #2730

Comments

@Justin-Credible
Copy link
Contributor

Justin-Credible commented Apr 7, 2020

Bug Report

Capacitor Version

npx cap doctor output:

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 2.0.0

  @capacitor/core: 2.0.0

  @capacitor/android: 2.0.0

  @capacitor/ios: 2.0.0

Installed Dependencies:

  @capacitor/cli 1.2.1

  @capacitor/core 1.2.1

  @capacitor/android 1.2.1

  @capacitor/ios 1.2.1


[success] Android looking great! 👌
  Found 3 Capacitor plugins for ios:
    cordova-plugin-spinner (1.1.0)
    cordova-plugin-telerik-imagepicker (2.3.3)
    shared-native-plugin (0.0.1)
[success] iOS looking great! 👌

Affected Platform(s)

  • Android
  • iOS
  • Electron
  • Web

Current Behavior

Using Capacitor.Plugins.Modals.showActions(...) on Android does not show the message or title attributes on Android.

https://github.com/ionic-team/capacitor/blob/master/android/capacitor/src/main/java/com/getcapacitor/plugin/Modals.java#L106

They are not being used in the creation of the modal. If this cannot be fixed, at least the documentation should indicate that title/message are not used on Android.

Expected Behavior

An action sheet should open with the passed title and message.

Sample Code or Sample Application Repo

Capacitor.Plugins.Modals.showActions({ title: "title", "message": "message", options: [{title: "yes"}, {title: "no"}, {title: "maybe"}] })

Reproduction Steps

Execute the following on iOS and Android. See that the message/title are shown on iOS but not Android.

Capacitor.Plugins.Modals.showActions({ title: "title", "message": "message", options: [{title: "yes"}, {title: "no"}, {title: "maybe"}] })
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant