Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): match platform version with cli version on add command #2724

Merged
merged 4 commits into from
Apr 8, 2020
Merged

fix(cli): match platform version with cli version on add command #2724

merged 4 commits into from
Apr 8, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Apr 7, 2020

Running cap add android should add the same version of the android platform as the rest of Capacitor. With these changes, it runs npm install @capacitor/<platform>@<version> so a very specific version is installed.

We could also look for the version of @capacitor/core, which might make more sense.

jcesarmobile
jcesarmobile requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, core version makes more sense since the types are there and things can go wrong if core version doesn’t match platform versions.
Also, there is a lint issue, can you fix it?

jcesarmobile
jcesarmobile approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jcesarmobile jcesarmobile changed the title fix(cli): install same version of platform fix(cli): make add install the platform version matching installed cli version Apr 8, 2020
@jcesarmobile jcesarmobile changed the title fix(cli): make add install the platform version matching installed cli version fix(cli): match platform version with cli version on add command Apr 8, 2020
@jcesarmobile jcesarmobile merged commit 6172932 into master Apr 8, 2020
@jcesarmobile jcesarmobile deleted the install-same-version branch April 8, 2020 18:27
@jcesarmobile jcesarmobile mentioned this pull request Apr 10, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imhoffd @jcesarmobile