Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set Icon in Share dialog #3049

Closed
2 of 4 tasks
josh-m-sharpe opened this issue Jun 4, 2020 · 5 comments
Closed
2 of 4 tasks

feat: ability to set Icon in Share dialog #3049

josh-m-sharpe opened this issue Jun 4, 2020 · 5 comments

Comments

@josh-m-sharpe
Copy link
Contributor

Feature Request

Describe the Feature Request

The interface that opens from the Share plugin Share.share(...) on iOS appears to have a default icon and there's no way to configure it.

This feature request is to update the plugin such that the default Icon doesn't appear.

ionic_share

Platform Support Requested

I've specifically noticed the issue on iOS and not on the Android devices and emulators that we use. However, I suppose it's Android has the same issue and we just haven't seen it.

  • Android
  • iOS
  • Electron
  • Web

Describe Preferred Solution

Default to the app icon

Describe Alternatives

  1. Ability to pass an icon to Share.share(...)
  2. No Icon at all
@jcesarmobile
Copy link
Member

That is really automatic, that icon means you are sharing text, if you share a http/https url you'll see the safari icon first and then the favicon of the website you are sharing, and if you share a file url like the one you get from the camera plugin when you take a picture a preview of the image appears.
But if you share both text and url, then the text icon appears.

@josh-m-sharpe
Copy link
Contributor Author

josh-m-sharpe commented Jun 4, 2020

@jcesarmobile Okay. Docs currently state: Each platform uses a different set of fields, but you should supply them all. - It seems that supplying text, overrides things in a negative or unclear way. Maybe the docs should be updated?

@jcesarmobile
Copy link
Member

Yeah, that sentence is wrong, I've removed it in #3051

In ShareOptions section you can see the ? on all params, that means they are optional. It also says dialogTitle is Android only, the other 3 work on both iOS and Android.

@josh-m-sharpe
Copy link
Contributor Author

It also seems that by not setting text, then when sharing by Gmail/Mail apps the the email subject is not populated. So that lets me choose between:

  1. no subject in email (poor user UX)
  2. no brand icon (poor marketing UX) -- for a Marketing feature.

I see other apps with sharing links that seem to have both a custom icon and populated email subjects.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants