Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove package-lock.json files #3093

Merged
merged 9 commits into from
Jun 12, 2020
Merged

chore: remove package-lock.json files #3093

merged 9 commits into from
Jun 12, 2020

Conversation

jcesarmobile
Copy link
Member

from core and cli, other packages don't have it or don't commit it

@imhoffd
Copy link
Contributor

imhoffd commented Jun 11, 2020

Please add a local .npmrc files to each package so the npm CLI doesn't re-add the lock files. (see https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/cli/.npmrc for an example)

imhoffd
imhoffd approved these changes Jun 11, 2020 •
edited
Loading
View reviewed changes
@jcesarmobile jcesarmobile merged commit 9cb36bb into ionic-team:master Jun 12, 2020
@jcesarmobile jcesarmobile deleted the remove-locks branch June 12, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcesarmobile @imhoffd