Plugin Template updates #3241
Merged
Plugin Template updates #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikeith
reviewed
Jul 13, 2020
Co-authored-by: Ian Keith <iankeith@gmail.com>
carlpoole
approved these changes
Jul 14, 2020
ikeith
approved these changes
Jul 14, 2020
|
After this changes, building a plugin takes an unreasonable amount of time (around 5 minutes on my computer) that makes it look like the process hanged. And build command output this, not sure if it might be a real problem
Also, lint command fails on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are for Capacitor 2.3. See planned changes to the plugin template for Capacitor 3 here: #3267
You can see a list of files the CLI generates from this PR here: https://github.com/ionic-team/capacitor-plugins/pull/1/files
resolves #3228