-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unified errors and error codes #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
changed the title
feat: UNIMPLEMENTED/UNAVAILABLE error codes
feat: unimplemented/unavailable error codes
Oct 13, 2020
imhoffd
changed the title
feat: unimplemented/unavailable error codes
feat: unified errors and error codes
Oct 16, 2020
jcesarmobile
requested changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two minor comments, other than that looks and works good.
jcesarmobile
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the base class of Capacitor exceptions to a new
Capacitor.Exception
class, allowing the following:Additionally, the
.unimplemented()
/.unavailable()
helpers on iOS, Android, and Web can now accept a message argument and use the new exception codes to allow the following:These codes make it easier for people to check what went wrong with Plugin API calls.
Because of the new availability of
UNAVAILABLE
on iOS and Web, it makes sense to removeUNSUPPORTED_BROWSER
and use unavailable instead. Usage example:closes #3670