-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically import Android plugins #3788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: android/capacitor/src/main/java/com/getcapacitor/BridgeActivity.java
carlpoole
approved these changes
Dec 1, 2020
android/capacitor/src/main/java/com/getcapacitor/PluginManager.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Carl Poole <mail@carlpoole.com>
jcesarmobile
approved these changes
Dec 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the Android Plugin Auto-registration Proposal.
TODO:
@NativePlugin
(?)Internally, the CLI creates a
capacitor.plugins.json
file insideandroid/app/src/main/assets
(alongsidecapacitor.config.json
) which is meant to be shipped in the final Android bundled app.This file contains a list of classpaths to the Capacitor plugins it finds during
npx cap update android
. It looks like this:Then, in Java, we use Reflection to load classes via
Class.forName()
.This simplifies the app developer workflow because they no longer need to use
add()
to add the class names to the list.MainActivity.java
in most apps can look like this:If they want to add app plugins, they need to do something like this:
depends on #3866depends on #3762resolves #3266