Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): avoid crash on portrait apps after taking a photo #3926

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fix(ios): avoid crash on portrait apps after taking a photo #3926

merged 1 commit into from
Dec 10, 2020

Conversation

jcesarmobile
Copy link
Member

closes #3910

supposedly the preferredInterfaceOrientationForPresentation override is not needed, according to the docs

If you do not implement this method, the system presents the view controller using the current orientation of the status bar.

and that's what our code does, but it crash on portrait only apps after taking a picture. Letting the view controller do its default doesn't crash.

https://developer.apple.com/documentation/uikit/uiviewcontroller/1621438-preferredinterfaceorientationfor

@imhoffd imhoffd merged commit f182868 into 2.x Dec 10, 2020
@imhoffd imhoffd deleted the fix-camera-rotation-crash branch December 10, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeith ikeith ikeith approved these changes

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcesarmobile @imhoffd @ikeith