Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): isNewBinary is true if defaults have no stored versions #4779

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix(ios): isNewBinary is true if defaults have no stored versions #4779

merged 1 commit into from
Jun 30, 2021

Conversation

Zapominacz
Copy link
Contributor

@Zapominacz Zapominacz commented Jun 30, 2021 •
edited by jcesarmobile
Loading

closes #4778

@jcesarmobile jcesarmobile changed the title fix(ios): fixed isNewBinary not to be always false fix(ios): isNewBinary is true if defaults have no stored versions Jun 30, 2021
jcesarmobile
jcesarmobile approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile merged commit bd86dbe into ionic-team:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: isNewBinary is always false
2 participants
@Zapominacz @jcesarmobile