Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: locate proper Info.plist based on the configured scheme for cordova plugin missing configurations #5755

Closed
puopg opened this issue Jul 8, 2022 · 2 comments · Fixed by #5914
Labels
platform: ios type: bug A confirmed bug report

Comments

@puopg
Copy link

puopg commented Jul 8, 2022

Feature Request

When checking cordova plugins, seems the file name for "Info.plist" is hardcoded. In the guide for Capacitor 3, the guide instructs developers to rename the Info.plist files to things like "App qa-Info.plist". If you are using cordova plugins, warnings start to appear that things may need to be added to the Info.plist, since its looking for the incorrect hardcoded Info.plist file.

This is happening in this method:

async function logiOSPlist(configElement: any, config: Config, plugin: Plugin) {

This request is to add support for environment specific configuration for what the Info.plist file is named, so that these warnings are properly reported.

Warnings that are displayed are like:

In Capacitor 3.3.3

[fatal] Unable to read: /Users/myUserName/Desktop/code/project/ios/App/App/Info.plist
[fatal] Unable to read: /Users/myUserName/Desktop/code/project/ios/App/App/Info.plist

And in Capacitor 3.6.0, they are no longer [fatal] errors, but warnings. A big improvement i must say than in 3.3.3 though!

Platform(s)

iOS

Cordova Plugin seen on

Launch Navigator: https://github.com/dpa99c/phonegap-launch-navigator

Preferred Solution

Maybe add a configuration option in the ios config in capacitor to allow developers to specify the name of the Info.plist file to use, default to "Info.plist" if not set to maintain compatibility.

@jcesarmobile jcesarmobile added the type: bug A confirmed bug report label Jul 11, 2022
@jcesarmobile
Copy link
Member

Thanks for the issue.
We already have a "scheme" config option for iOS, but it's not being used for locating the Info.plist path, so it's a bug, not a feature request.

@jcesarmobile jcesarmobile changed the title [Feature Request]: Allow environment specific configurations for Info.plist files for cordova plugins. bug: locate proper Info.plist based on the configured scheme for cordova plugin missing configurations Jul 11, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 10, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: ios type: bug A confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants