fix: allow single parameter on setRequestBody #6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Jul 13, 2023
IT-MikeS
approved these changes
Jul 13, 2023
markemer
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public setRequestBody method was modified to add a new parameter, but since it's public it can break (and breaks on iOS) plugins or custom user code using the method with less parameters.
This PR allows to keep using the previous number of parameters.
Also adds a null check on Android for
bodyTypeas you can't call.equalson a null object andbodyTypecan benullsince it's marked as optional on the types, so the call togetString()where it gets the value could returnnull.closes #6727
closes ionic-team/capacitor-plugins#1682