fix: Add more server checks before loading urls or reloading #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
force-pushed
the
more-server-checks
branch
from
b96b3ac
to
577a4ff
Compare
mlynch
reviewed
Nov 9, 2018
src/ios/CDVWKWebViewEngine.m
Outdated
| @"<head><title>Error</title></head>" | ||
| @" <div style='font-size:2em'>" | ||
| @" <p>The App Server is not running.</p>" | ||
| @" <p>Close other apps and try again.</p>" |
There was a problem hiding this comment.
Can you change this specific sentence to "Restart the app"
There was a problem hiding this comment.
Actually, remove both lines, and do:
<p><b>Error</b></p>
<p>Unable to load app.</p>Add more server ckecks before loading urls or reloading, also check for socket
jcesarmobile
force-pushed
the
more-server-checks
branch
from
577a4ff
to
90e21d3
Compare
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more server ckecks before loading urls or reloading, also check for socket unknown errors