Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Add WKSuspendInBackground preference #356

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

jcesarmobile
Copy link
Member

No description provided.

@jcesarmobile jcesarmobile merged commit 3613602 into ionic-team:master Apr 22, 2019
@jcesarmobile jcesarmobile deleted the suspend-again branch April 22, 2019 17:54
Ionitron added a commit that referenced this pull request Jun 10, 2019
# [4.1.0](v4.0.1...v4.1.0) (2019-06-10)

### Features

* **ios:** Add WKSuspendInBackground preference ([#356](#356)) ([3613602](3613602))
@Ionitron
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@l3ender
Copy link

l3ender commented Jun 28, 2019

I'm curious about how this PR works. What are the magic strings for, and why does setting them in WKWebViewConfiguration make a difference?

@heikomat
Copy link

heikomat commented Jul 4, 2019

@l3ender As can be determined by the followup lines, these are base64 encoded strings.
The first one decodes to
alwaysRunsAtForegroundPriority
and the second one to
_alwaysRunsAtForegroundPriority

@l3ender
Copy link

l3ender commented Jul 5, 2019

@heikomat Thanks for the response. Don't know how I missed that (not fluent in Obj C, but still pretty obvious).

Why do the strings need to be encoded?

@zbarbuto
Copy link

zbarbuto commented Jul 22, 2019

@l3ender As can be determined by the followup lines, these are base64 encoded strings.
The first one decodes to
alwaysRunsAtForegroundPriority
and the second one to
_alwaysRunsAtForegroundPriority

So if Apple ever decides to rename those functions this preference will break silently?

ilyasfoo pushed a commit to ilyasfoo/cordova-plugin-ionic-webview that referenced this pull request Aug 5, 2019
@chrisjdev
Copy link

Isn't this a really bad idea? Looks like there's some details in #286

@Andrewpk
Copy link

This is a terrible idea. The strings are base64 encoded so Apple's AppStore review scan will generally pass right over them. If Apple finds this, they'll reject and possibly mass-reject/pull any ionic apps using wkwebview.

This should be changed immediately as it is in direct opposition to the AppStore review guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants