-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): Add WKSuspendInBackground preference #356
Conversation
# [4.1.0](v4.0.1...v4.1.0) (2019-06-10) ### Features * **ios:** Add WKSuspendInBackground preference ([#356](#356)) ([3613602](3613602))
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm curious about how this PR works. What are the magic strings for, and why does setting them in |
@l3ender As can be determined by the followup lines, these are base64 encoded strings. |
@heikomat Thanks for the response. Don't know how I missed that (not fluent in Obj C, but still pretty obvious). Why do the strings need to be encoded? |
So if Apple ever decides to rename those functions this preference will break silently? |
Isn't this a really bad idea? Looks like there's some details in #286 |
This is a terrible idea. The strings are base64 encoded so Apple's AppStore review scan will generally pass right over them. If Apple finds this, they'll reject and possibly mass-reject/pull any ionic apps using wkwebview. This should be changed immediately as it is in direct opposition to the AppStore review guidelines. |
No description provided.