BREAKING: remove RequiresApi and drop support for API 19 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Mar 30, 2020
There was a problem hiding this comment.
You also have to remove the TargetApi import (https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/src/android/com/ionicframework/cordova/webview/IonicWebViewEngine.java#L7)
TargetApi usage
https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/src/android/com/ionicframework/cordova/webview/IonicWebViewEngine.java#L128-L132
and the annotation library from plugin.xml
https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/plugin.xml#L55-L56
And since this is breaking, we might want to do a minor release before merging this
imhoffd
changed the title
jcesarmobile
approved these changes
May 11, 2020
Ionitron
added a commit
that referenced
this pull request
May 27, 2020
# [5.0.0](v4.2.1...v5.0.0) (2020-05-27) ### Features * **android:** remove RequiresApi annotation and drop support for API 19 ([#540](#540)) ([17d2ada](17d2ada)) * **ios:** remove normalizeURL function ([#576](#576)) ([d5bdbaa](d5bdbaa)) * **ios:** remove wkRewriteURL function ([#577](#577)) ([02c18ea](02c18ea)) ### BREAKING CHANGES * **ios:** wkRewriteURL was deprecated and has been removed, use window.Ionic.WebView.convertFileSrc instead * **ios:** normalizeURL was deprecated and has been removed, use window.Ionic.WebView.convertFileSrc instead * **android:** Drop Android 4.4 support (SDK API level 19). Min required is 21.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lempere
pushed a commit
to we-are-Joinup/cordova-plugin-ionic-webview
that referenced
this pull request
Sep 23, 2020
… 19 (ionic-team#540) BREAKING CHANGE: Drop Android 4.4 support (SDK API level 19). Min required is 21. (cherry picked from commit 17d2ada)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for API 19 and adds support for API 29 and can be merged after cordova-android 9 is released.