Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Only delete relevant files/directories in the www directory #134

Closed
brandyscarney opened this issue Oct 11, 2016 · 6 comments
Closed

Only delete relevant files/directories in the www directory #134

brandyscarney opened this issue Oct 11, 2016 · 6 comments

Comments

@brandyscarney
Copy link
Member

Short description of the problem:

Currently the build is deleting everything in the www/ directory. If I have a file in my www/ directory it gets erased on build. I could put the file in another directory and add a custom config but this seems like overkill for one file.

What behavior are you expecting?

Either be able to add specific files to ignore from deletion in the www/ directory or only have the relevant files in www/ deleted for a build.

Steps to reproduce:

  1. Clone the conference app: https://github.com/driftyco/ionic-conference-app
  2. Run ionic serve
  3. See that the .gitignore file is deleted inside of www/ and all other files in www/ are showing up to add to git

Which @ionic/app-scripts version are you using?

0.0.30

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Related to: #127

@brandyscarney
Copy link
Member Author

@adamdbradley @danbucholtz Thoughts on how this should be handled?

@danbucholtz
Copy link
Contributor

It sounds like we should only delete the www/build directory going forward.

What does this mean for the assets directory, though?

Thanks,
Dan

@adamdbradley
Copy link
Contributor

The recent updates has it so only www/build gets deleted.

@marcoturi
Copy link
Contributor

i still get all the folder cleaned (app-scripts 0.34)

@brandyscarney
Copy link
Member Author

@marcoturi hmm I'm not seeing the folder cleaned using the conference app. Could you clone that and see if it happens for you there? https://github.com/driftyco/ionic-conference-app

@marcoturi
Copy link
Contributor

my bad, i didn't run npm install after updating package.json, was using app-scripts 0.30.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants