Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: ion-backdrop basic usage demo should have tinted backdrop #3110

Closed
harlig opened this issue Sep 8, 2023 · 5 comments · Fixed by #3200
Closed

content: ion-backdrop basic usage demo should have tinted backdrop #3110

harlig opened this issue Sep 8, 2023 · 5 comments · Fixed by #3200
Labels
content Issues related to the contents of the documentation website

Comments

@harlig
Copy link

harlig commented Sep 8, 2023

Describe the Bug

The "basic usage" example of the ion-backdrop page isn't functional. Clicking on it does nothing.

Expected Behavior

The example should demonstrate the backdrop functionality.

Steps to Reproduce

  1. Navigate to ion-backdrop docs page
  2. Go to "Basic Usage" section
  3. Attempt to interact with the example

Screenshots

ion-backdrop.mov

Operating System

No response

Browser

Firefox 117.0

Version

No response

Additional Information

No response

@harlig harlig added the triage New issues label Sep 8, 2023
@averyjohnston averyjohnston self-assigned this Sep 8, 2023
@averyjohnston
Copy link
Contributor

Thank you for the issue. As described in the paragraph above the demo, the behavior you're describing actually is the backdrop functionality -- it prevents clicking or tapping on any of the elements underneath it. Does that help answer your question?

@averyjohnston averyjohnston added the needs: reply Issues that need more information from the author label Sep 8, 2023
@averyjohnston averyjohnston removed their assignment Sep 8, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label Sep 8, 2023
@harlig
Copy link
Author

harlig commented Sep 8, 2023

I did see that but I guess the example was then confusing to me since it doesn't feel like it's truly demonstrating the backdrop functionality. The following example showing a clickable overlay paired with the backdrop seems like a much more common use case and perhaps should be used as the primary example.

@ionitron-bot ionitron-bot bot added triage New issues and removed needs: reply Issues that need more information from the author labels Sep 8, 2023
@averyjohnston
Copy link
Contributor

Would it help if the backdrop was tinted to better mimic the functionality it'd have in an overlay? The idea behind the demo is to show the backdrop's functionality by itself, without implying that it necessarily needs to be used with any other components.

@averyjohnston averyjohnston added the needs: reply Issues that need more information from the author label Sep 11, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label Sep 11, 2023
@harlig
Copy link
Author

harlig commented Sep 12, 2023

Personally that'd be more clear to me. I understand the desire to show the basic usage without any other components, I just think for this component in particular it may make sense to show with a tinted backdrop.

@ionitron-bot ionitron-bot bot added triage New issues and removed needs: reply Issues that need more information from the author labels Sep 12, 2023
@averyjohnston averyjohnston changed the title bug: ion-backdrop - "Basic Usage" example isn't functional content: ion-backdrop basic usage demo should have tinted backdrop Sep 12, 2023
@averyjohnston averyjohnston added the content Issues related to the contents of the documentation website label Sep 12, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label Sep 12, 2023
@averyjohnston
Copy link
Contributor

I've added a tint to the backdrop in #3200. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues related to the contents of the documentation website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants