Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding list sliding items not working in RTL #10219

Closed
theunreal opened this issue Jan 28, 2017 · 6 comments
Closed

Sliding list sliding items not working in RTL #10219

theunreal opened this issue Jan 28, 2017 · 6 comments

Comments

@theunreal
Copy link

theunreal commented Jan 28, 2017

Ionic version: (check one with "x")
[ ] 1.x
[x ] 2.x

I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
Sliding list don't show the sliding buttons correctly and few issues with the display.
Before sliding:
image
After sliding left:

image

After sliding right:
image

After sliding more and more right:

image

Expected behavior:

  • Sliding list should work and show the sliding buttons when trying to slide.
  • the ion lines should not be displayed under the buttons
  • Buttons should appeaer from the right side

Steps to reproduce:
Use ion sliding list in any RTL app

Related code:

<ion-list>
  <ion-item-sliding>
<ion-item *ngFor="let message of chatMessages | async">
    <h2>test 1</h2>
    <p>test 2</p>
</ion-item>
<ion-item-options side="right">
      <button ion-button color="primary">
        <ion-icon name="text"></ion-icon>
        Button 1
      </button>
    </ion-item-options>
    <ion-item-options side="left">
      <button ion-button color="primary">
        <ion-icon name="remove-circle"></ion-icon>
        Button 2
      </button>
          <button ion-button color="primary">
            <ion-icon name="trash"></ion-icon>
            Button 3
          </button>
        </ion-item-options>
  </ion-item-sliding>
</ion-list>

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.5
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.2
Xcode version: Not installed
@theunreal theunreal reopened this Jan 28, 2017
@aihilali
Copy link

I used to have problems with ionic 2 sliding items when using RC versions, try to update ionic to final and the problem will be solved.

@theunreal
Copy link
Author

@Abderrahmane-H It solves the problem only if style="direction:ltr" is set, RTL is same - not working correctly.

@aihilali
Copy link

yes you are right , well there is a workaround until there is a fix :
-set the ion-item-sliding direction to ltr, dir="ltr" or by using sass
-set the ion-item direction to rtl,
this is one solved that issue for a blank app set to 'rtl' edited to have sliding items .

@theunreal
Copy link
Author

theunreal commented Jan 28, 2017

@Abderrahmane-H This is just about my previous comment... it is a workaround but this issue still need to be fixed

@jgw96 jgw96 added the v2 label Jan 30, 2017
@jgw96
Copy link
Contributor

jgw96 commented Jan 30, 2017

Hello, thanks for opening an issue with us! I am going to close this issue as a duplicate of #8107.

@jgw96 jgw96 closed this as completed Jan 30, 2017
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 4, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants