Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll not working on Android 2.3.6 Gingerbread #1062

Closed
rvanbaalen opened this issue Apr 6, 2014 · 10 comments
Closed

Scroll not working on Android 2.3.6 Gingerbread #1062

rvanbaalen opened this issue Apr 6, 2014 · 10 comments
Assignees

Comments

@rvanbaalen
Copy link

I know this platform hasn't the highest priority but since I couldn't find any related issue report I'm reporting this anyway.

On a Samsung Galaxy S1 running Android Gingerbread 2.3.6 I can't scroll any scrollable view. That about sums it up and doesn't need much extra explanation or a codepen since it happens in any scrollable view (<ion-content scroll="true">)

@adamdbradley adamdbradley self-assigned this Apr 7, 2014
@adamdbradley
Copy link
Contributor

I tested ion-content scroll="true" on an Android 2.3 and it was still scrolling. If your app scrolls on all other devices except 2.3, I'd suspect it's from this line:
https://github.com/driftyco/ionic/blob/master/js/views/scrollView.js#L622

Would you be able to help debug this? I'm unable to replicated the issue, thanks.

@rvanbaalen
Copy link
Author

I will give this some debugging later. Android 2.3(.6) doesn't have my highest priority for the 1.0 launch of my app. Thanks for pointing my nose in the right direction.

@emertechie
Copy link

Had the same issue using the beta.1 version and did a bit of digging. Appears it's the e.target.dataset bit in the shouldIgnorePress function. The dataset property doesn't exist.

function shouldIgnorePress(e) {
  // Don't react if initial down happens on a form element
  return e.target.tagName.match(IS_INPUT_LIKE_REGEX) ||
         e.target.isContentEditable ||
         e.target.tagName.match(IS_EMBEDDED_OBJECT_REGEX) ||
         e.target.dataset.preventScroll;  // << This causes the problem
}

Quickly changing mine to (e.target.dataset ? e.target.dataset.preventScroll : false) "solved" the issue but I don't know the implications. That area of code seems to have changed on master so not sure if it's still an issue there.

@ajoslin
Copy link
Contributor

ajoslin commented Apr 9, 2014

This was fixed in nightly awhile ago - closing!

good research though @emertechie :-)

@ajoslin ajoslin closed this as completed Apr 9, 2014
@rvanbaalen
Copy link
Author

Awesome! I'll give this a go when I'm home (where the Galaxy S1 Android
2.3.6 is enjoying his retirement).

I'll post my findings / confirmation here.

@ajoslin
Copy link
Contributor

ajoslin commented Apr 9, 2014

Oh sorry, I thought this was an older and different issue related to beta.1 that forgot to be fixed. My bad. Reopening for adam.

However, it may work now .. Not sure.

@ajoslin ajoslin reopened this Apr 9, 2014
@rvanbaalen
Copy link
Author

Aah bummer. I guess Ill have to be more patient then.

@JeanCarriere
Copy link

Not sure if it's the same issue but it might be : #772
I have exactly the same problem but on a Samsung running on 4.3.

@ajoslin ajoslin closed this as completed Apr 30, 2014
@eriwangi08
Copy link

I'm running android 5.1.1 on Samsung Galaxy Tab A (2016). I have implemented a webview and androidpdfviewer and i'm experiencing the scroll issue.
Kindly assist.

This is the sample code

<!-- TOP SECTION WITH HEADER-->
<LinearLayout
    android:id="@+id/top_section"
    android:layout_width="match_parent"
    android:layout_height="24dp"
    android:layout_marginLeft="20dp"
    android:layout_marginRight="20dp"
    android:layout_marginTop="1dp"
    android:orientation="horizontal">

    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content">

        <sg.utmobile.core.ui.view.UtTextView
            android:id="@+id/text_form_title"
            style="@style/General.Component.Text.Header.Fragment"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:tag="text_form_title"
            android:text="Document Preview"
            android:visibility="visible" />

        <View
            android:id="@+id/header_line"
            style="@style/title_line"
            android:tag="header_line" />
    </LinearLayout>
</LinearLayout>

<RelativeLayout
    android:layout_width="match_parent"
    android:layout_height="850dp"
    android:layout_marginBottom="5dp"
    android:layout_marginTop="5dp"
    android:gravity="center">

    <!-- PDF REGION -->
    <!--<com.github.barteksc.pdfviewer.PDFView
        android:id="@+id/grid_pdf_viewer"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:layout_marginBottom="60dp"
        android:isScrollContainer="true"
        android:scrollbars="vertical"
        android:tag="grid_pdf_viewer"
        android:visibility="visible"></com.github.barteksc.pdfviewer.PDFView>-->
    <ScrollView
        android:layout_width="match_parent"
        android:layout_height="850dp">

        <sg.utmobile.core.ui.view.UtWebView
            android:id="@+id/grid_pdf_viewer"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_marginBottom="60dp"
            android:overScrollMode="always"
            android:tag="grid_pdf_viewer"
            android:visibility="visible"></sg.utmobile.core.ui.view.UtWebView>
    </ScrollView>

    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentBottom="true"
        android:orientation="horizontal">

        <sg.utmobile.core.ui.view.UtCheckbox
            android:id="@+id/chk_read_loan_doc"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="center"
            android:layout_marginLeft="8dp"
            android:button="@drawable/custom_checkbox_selector"
            android:checked="false"
            android:soundEffectsEnabled="false"
            android:tag="chk_read_loan_doc" />

        <sg.utmobile.core.ui.view.UtTextView
            android:id="@+id/txt_read_loan_doc"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_marginLeft="3dp"
            android:layout_marginTop="2dp"
            android:tag="txt_read_loan_doc"
            android:text="I have read and understood the loan document"
            android:textAllCaps="true"
            android:textColor="@color/black"
            android:textSize="16dp"
            mobile:font="Ubuntu-R" />

        <sg.utmobile.core.ui.view.UtButton
            android:id="@+id/button_dismiss"
            android:layout_width="wrap_content"
            android:layout_height="@dimen/component_height_normal"
            android:layout_alignParentRight="true"
            android:layout_marginLeft="10dp"
            android:layout_marginRight="2dp"
            android:layout_toRightOf="@id/button_clear"
            android:background="@drawable/form_button_selector"
            android:paddingLeft="12dp"
            android:paddingRight="12dp"
            android:singleLine="true"
            android:tag="button_dismiss"
            android:text="CONFIRM"
            android:textAllCaps="true"
            android:textColor="@color/text_color_1"
            android:textSize="@dimen/text_font_size_normal"
            mobile:font="Ubuntu-R" />

    </LinearLayout>
</RelativeLayout>

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants