Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peer dep on Angular #12638

Closed
danbucholtz opened this issue Aug 10, 2017 · 3 comments
Closed

Remove peer dep on Angular #12638

danbucholtz opened this issue Aug 10, 2017 · 3 comments

Comments

@danbucholtz
Copy link
Contributor

Get rid of the peer dependencies on angular in ionic-angular. We are getting rid of peer deps everywhere as they cause more trouble than they're worth. This particular change is at the request of the stack blitz developer.

Thanks,
Dan

@jgw96 jgw96 added the v3 label Aug 10, 2017
@soumak77
Copy link
Contributor

@danbucholtz why must the peer dependencies be removed? Ionic hard-codes all version numbers which causes the issue. Seems like using a proper version range will solve this issue.

@soumak77
Copy link
Contributor

soumak77 commented Sep 8, 2017

@jgw96 @danbucholtz any idea when this will be completed? Also, can I request the peer dependency on rxjs to also be removed or have the version range fixed (see #11741 (comment))

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 8, 2018

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Sep 8, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants