Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ionic v4] ion-item button ion-ripple-effect only on click not on touch #15752

Closed
peterpeterparker opened this issue Sep 25, 2018 · 1 comment
Assignees

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Sep 25, 2018

Feature Request

I would like to submit a feature request

Ionic Info

Ionic Angular v4-beta.7

Describe the Feature Request
I've got an ion-list which contains many ion-item button for which I would like to add the ion-ripple-effect

The effect itself works fine, I just noticed one thing while testing on my iPhone 6s that I think could be improved, at least in my case that would be cool:

The ripple effect for such elements should only be triggered on click event and not on touch event, otherwise, when the user would scroll the list, then the ripple effect will be triggered/displayed too what is a bit misleading since nothing happens except that the list is scrolled

Actual behavior:

touch and scroll => ripple effect
click => ripple effect

Proposed behavior:

touch and scroll => no ripple effect
click => ripple effect

Related Code

<ion-list>
  <ion-item *ngFor="let i of 100" button (click)="myAction()">
      <ion-ripple-effect></ion-ripple-effect>
      <ion-label>Something</ion-label>
  </ion-item>
</ion-list>

Additional Context
Tested on an iPhone 6s (video): https://www.dropbox.com/s/28vi7w5avxdvo27/ripple.mov?dl=0

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 25, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants