You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the Feature Request
I've got an ion-list which contains many ion-item button for which I would like to add the ion-ripple-effect
The effect itself works fine, I just noticed one thing while testing on my iPhone 6s that I think could be improved, at least in my case that would be cool:
The ripple effect for such elements should only be triggered on click event and not on touch event, otherwise, when the user would scroll the list, then the ripple effect will be triggered/displayed too what is a bit misleading since nothing happens except that the list is scrolled
Actual behavior:
touch and scroll => ripple effect
click => ripple effect
Proposed behavior:
touch and scroll => no ripple effect
click => ripple effect
Related Code
<ion-list>
<ion-item *ngFor="let i of 100" button (click)="myAction()">
<ion-ripple-effect></ion-ripple-effect>
<ion-label>Something</ion-label>
</ion-item>
</ion-list>
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
Feature Request
I would like to submit a feature request
Ionic Info
Ionic Angular v4-beta.7
Describe the Feature Request
I've got an
ion-list
which contains manyion-item button
for which I would like to add the ion-ripple-effectThe effect itself works fine, I just noticed one thing while testing on my iPhone 6s that I think could be improved, at least in my case that would be cool:
The ripple effect for such elements should only be triggered on
click
event and not ontouch
event, otherwise, when the user would scroll the list, then theripple
effect will be triggered/displayed too what is a bit misleading since nothing happens except that the list is scrolledActual behavior:
touch and scroll => ripple effect
click => ripple effect
Proposed behavior:
touch and scroll => no ripple effect
click => ripple effect
Related Code
Additional Context
Tested on an iPhone 6s (video): https://www.dropbox.com/s/28vi7w5avxdvo27/ripple.mov?dl=0
The text was updated successfully, but these errors were encountered: