Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Collection-repeat item swipe issue #1842

Closed
h4ck3rviv3k opened this issue Jul 25, 2014 · 5 comments
Closed

bug: Collection-repeat item swipe issue #1842

h4ck3rviv3k opened this issue Jul 25, 2014 · 5 comments
Milestone

Comments

@h4ck3rviv3k
Copy link

Type: bug

Platform: all

In collection-repeat if user swipe on any element then it will reveal some buttons and while these buttons are being shown if user scrolls down then the element at the same position down also get swiped and it keeps repeating as we scroll down.

@christoph-hummel
Copy link

+1

@ajoslin
Copy link
Contributor

ajoslin commented Aug 6, 2014

Will be fixed soon.

@krlwlfrt
Copy link

+1

@ajoslin
Copy link
Contributor

ajoslin commented Feb 5, 2015

Fixed via e90477c

@ajoslin ajoslin closed this as completed Feb 5, 2015
@ajoslin ajoslin removed the ready label Feb 5, 2015
@ajoslin ajoslin reopened this Feb 7, 2015
@ajoslin
Copy link
Contributor

ajoslin commented Feb 7, 2015

The fix makes it so when you scroll away from a swiped item, it closes. But it doesn't make the swiped item reopen when you scroll back to it.

This is because it's not possible with collectionRepeat's current implementation to store state on any of the items once they're scrolled away. Eg say, "this item was swiped open".

I could hack it in, but it would be really dirty and really fragile.

I'll wait until collectionRepeat's next iteration to add this functionality.

@ajoslin ajoslin modified the milestones: 1.1, 1.0.0-rc0 Feb 7, 2015
@mhartington mhartington modified the milestones: 1.1, 1.2 Aug 15, 2015
@mhartington mhartington modified the milestones: 1.2, 1.1 Aug 15, 2015
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants