-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow vue router to be overrided instead of created #24991
Comments
Thanks for the issue. Can you please provide a GitHub repo that I can use to reproduce this issue? |
Yes, the base repo I use is : |
Thanks for the additional information. I think it would be better to have Vitesse allow for custom routing instances rather than have Ionic Vue support 3rd party routing setups. Have you tried opening an issue with the project maintainers? |
@liamdebeasi Vitesse is overlapping the router for SSG/SSR and routes are auto-generated by a plugin, this is the whole concept of it to do it for you as Nuxt does, i didn't ask them since that the point of it to handle server-side routing. |
Hey @riderx thanks for this feature request. Based on our previous discussions here: #24971 (comment) and discussing this feature request with the team; we believe it is best to open a new feature request focused around decoupling We appreciate your suggestions on how we can continue to improve Ionic to work with other development solutions and concepts 👍 I am going to close out this request, you can track the new feature request here: #25184. Feel free to add any thoughts to that issue! Thanks! |
@sean-perkins thanks a lot for this! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Describe the Feature Request
i would like to have
overrideRouter
method to allow me to use ionic router feature like animations by including in existing router.After check both code it seems on the ionic side the router init have nothing special. so it can be done by the user or other module.
Describe the Use Case
i use (vite-ssg)[https://github.com/antfu/vite-ssg] in my Vueapp.
it create the router for me, so i can't use ionic router too.
Describe Preferred Solution
No response
Describe Alternatives
No response
Related Code
ionic code of router creation :
ionic-framework/packages/vue-router/src/index.ts
Line 16 in c52f3ad
vite-ssg router creation :
https://github.com/antfu/vite-ssg/blob/3adec80118d6f008fd2f6ffafcc08cb0101284ce/src/client/index.ts#L38
Additional Information
No response
The text was updated successfully, but these errors were encountered: