refactor(toast): remove cssClass from ToastButton #28977

thetaPC · 2024-02-05T17:31:49Z

Issue number: internal

What is the current behavior?

The deprecated cssClass is still part of ToastButton even though the buttons can be access through shadow parts.

Removed cssClass from ToastButton
Updated the Breaking Change file to inform developers that they can add their styles through the "button" shadow part.

N/A

…nto FW-4923

BREAKING.md

core/src/components/toast/toast-interface.ts

…nto FW-4923

refactor(toast): remove cssClass from ToastButton

41bc351

github-actions bot added the package: core @ionic/core package label Feb 5, 2024

thetaPC marked this pull request as ready for review February 5, 2024 18:20

thetaPC requested a review from a team as a code owner February 5, 2024 18:20

thetaPC requested review from brandyscarney and removed request for a team February 5, 2024 18:20

Merge branch 'feature-8.0' of github.com:ionic-team/ionic-framework i…

c636ba2

…nto FW-4923

brandyscarney reviewed Feb 5, 2024

View reviewed changes

BREAKING.md Show resolved Hide resolved

refactor(toast): add requested change

10d5d9d

thetaPC requested a review from brandyscarney February 5, 2024 22:29

brandyscarney requested changes Feb 6, 2024

View reviewed changes

core/src/components/toast/toast-interface.ts Outdated Show resolved Hide resolved

thetaPC added 2 commits February 6, 2024 08:34

fix(toast): revert removal from ToastOptions

9a5ef87

Merge branch 'feature-8.0' of github.com:ionic-team/ionic-framework i…

4425f92

…nto FW-4923

brandyscarney approved these changes Feb 6, 2024

View reviewed changes

Merge branch 'feature-8.0' of github.com:ionic-team/ionic-framework i…

656181d

…nto FW-4923

thetaPC merged commit 9856295 into feature-8.0 Feb 6, 2024
44 checks passed

thetaPC deleted the FW-4923 branch February 6, 2024 17:09