feat(datetime): add showAdjacentDays to display days from the previous and next months #30262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JoaoFerreira-FrontEnd merged 62 commits into feature-8.6 from ROU-11118_V2

Mar 19, 2025

Contributor

JoaoFerreira-FrontEnd commented Mar 17, 2025 •

edited

Loading

Issue number: Internal

What is the new behavior?

Adds a new property to datetime, showAdjacentDays, that when true will show the last days of the previous month and the first days of the next month. This will just occupy empty "cells" at the beginning of the month "table" and add rows to the table until a maximum of 6 rows are displayed.

Changes

add styles for adjacent day button
add showAdjacentDays property to datetime component
change month generation to respect new property
add visual tests to new feature

Does this introduce a breaking change?

Yes
No

Other information

JoaoFerreira-FrontEnd and others added 30 commits

February 24, 2025 18:44


          - add styles for hidden day button;

af7472b

- add showDaysOutsideCurrentMonth property to datetime  component;
- change month generation to respect new property;


          - fix focus of hidden day;

8c2d033

- create specific test page for showDaysOutsideCurrentMonth;


          - add styles for hidden-days on md and ios themes;

6dd9bc4


          - ensure hidden days styles are not applied on disable days;

7fe2359


          - add visual tests to new feature;

4ba73b0


          - lint.fix

a2b4473


          - remove custom wheel example;

a908402


          - update snapshots;

9cd8a3c


          - fix snapshots;

4cef43e


          Update core/src/components/datetime/datetime.md.scss

970b52c

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/datetime.md.scss

37457dd

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

08119cc

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

6aca32d

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/utils/data.ts

64a92f8

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

cb835af

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/datetime.tsx

d1fed86

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

2d332d5

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/datetime.tsx

2d671d0

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

e4de5db

…index.html

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/datetime.tsx

e2393a5

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

9ec10fb

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

08e2990

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

0eca20e

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

e219fc7

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

185feef

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

de4c6af

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

f61d607

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

8b8ddcb

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

f4867c4

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>


          Update core/src/components/datetime/test/showDaysOutsideCurrentMonth/…

68f331d

…datetime.e2e.ts

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>

brandyscarney reviewed

View reviewed changes

Member

brandyscarney left a comment

Looks good just requested a couple things!

packages/angular/src/directives/proxies.ts Show resolved Hide resolved

core/package-lock.json Show resolved Hide resolved

brandyscarney requested review from thetaPC and removed request for christian-bromann

March 17, 2025 19:23

JoaoFerreira-FrontEnd added 2 commits

March 18, 2025 15:05


          - update angular package directives;

595611e


          - revert package-lock

809b267

vercel bot deployed to Preview

March 18, 2025 15:09

View deployment


          revert package-lock

f01afd9

vercel bot deployed to Preview

March 18, 2025 15:13

View deployment

JoaoFerreira-FrontEnd added 2 commits

March 18, 2025 15:15


          revert package-lock

596ced9


          - revert .\ package-lock

8b646bc

vercel bot deployed to Preview

March 18, 2025 15:17

View deployment


          - update .\ package-lock

19d0cdc

vercel bot deployed to Preview

March 18, 2025 15:24

View deployment

brandyscarney approved these changes

View reviewed changes

thetaPC requested changes

View reviewed changes

core/src/components/datetime/datetime-interface.ts Outdated Show resolved Hide resolved

core/src/components/datetime/datetime.tsx Outdated Show resolved Hide resolved

core/src/components/datetime/utils/data.ts Outdated Show resolved Hide resolved

core/src/components/datetime/utils/data.ts Outdated Show resolved Hide resolved

JoaoFerreira-FrontEnd and others added 3 commits

March 19, 2025 10:08


          Update core/src/components/datetime/datetime.tsx

c936ec6

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>


          Update core/src/components/datetime/utils/data.ts

3ea9185

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>


          Update core/src/components/datetime/utils/data.ts

cceacd7

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>

vercel bot deployed to Preview

March 19, 2025 10:12

View deployment


          - change datetime attribute naming;

448d170

vercel bot deployed to Preview

March 19, 2025 12:11

View deployment

thetaPC requested changes

View reviewed changes

core/src/components/datetime/datetime.tsx Outdated Show resolved Hide resolved

core/src/components/datetime/datetime.tsx Outdated Show resolved Hide resolved

core/src/components/datetime/datetime.tsx Outdated Show resolved Hide resolved

JoaoFerreira-FrontEnd and others added 3 commits

March 19, 2025 15:44


          Update core/src/components/datetime/datetime.tsx

e033e36

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>


          Update core/src/components/datetime/datetime.tsx

5f41ff3

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>


          Update core/src/components/datetime/datetime.tsx

2e35911

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>

vercel bot deployed to Preview

March 19, 2025 15:48

View deployment

thetaPC approved these changes

View reviewed changes

Contributor

thetaPC left a comment

LGTM

JoaoFerreira-FrontEnd merged commit b67259e into feature-8.6

48 checks passed

JoaoFerreira-FrontEnd deleted the ROU-11118_V2 branch

March 19, 2025 16:39

JoaoFerreira-FrontEnd mentioned this pull request

feat(ion-datetime): add hidden-days when theme:ionic #30205

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular package: core package: vue