bug: JS SyntaxError on v1-0-0-beta-14-nightly-998

[luchusnet]

Type: bug

Platform: android 2.x webview

02-05 16:22:26.445: D/CordovaLog(14066): file:///android_asset/www/js/libs/ionic/js/ionic.bundle.js: Line 23905 : Uncaught SyntaxError: Unexpected token finally

on android version 2.3x

[adamdbradley]

I'm unable to get this error on Android 2.3. Could you fork one of these codepens and describe how to get the error to show up? Thanks

[luchusnet]

Use codepens its complicated because our project ( a social network ) uses several " plugins" and depends on several http services that should be mocked.

But looking the line with the error, noticed that ".finally" is reserved sentence. Then I found this post:

kriskowal/q#200

Then I changed the original line of ionic.bundle.js 23919: .finally (function () by ["finally"] (function () and it worked!

I guess "finally" is a reserved name can not be used as a method in some android browsers.

The phone I used is:

Samsung GT-S5360L
Android version: 2.3.6

So, this is a bug?

[adamdbradley]

I'm not finding a .finally anywhere in this file: http://code.ionicframework.com/1.0.0-beta.14/js/ionic.bundle.js (that isn't in a code comment)

It sounds like it was originally within Angular source code, then angular recently updated it. Would you be able to find the line you're having the problem with using one of our versions on the CDN? Thanks

[luchusnet]

Sorry, its in nightly: 1-0-0-beta-14-nightly-998

[adamdbradley]

Great catch! I'll take a look, thanks!

[adamdbradley]

I added a temporary fix and submitted a PR to angular: 1f2d900

thanks